Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move common.fires() to inspector-helper #17401

Closed
wants to merge 1 commit into from
Closed

test: move common.fires() to inspector-helper #17401

wants to merge 1 commit into from

Commits on Dec 4, 2017

  1. test: move common.fires() to inspector-helper 

    common.fires() is specific to the inspector tests so move it to
inspector-helper.js. The one REPL test that used common.fires() does not
seem to need it. It provided a 1 second timeout for operations, but that
timeout appears both arbitrary and ineffective as the test passes if it
is reduced to even 1 millisecond.
    @Trott
    Trott committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    1015287 View commit details
    Browse the repository at this point in the history