Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use Countdown in http test #17436

Closed
wants to merge 1 commit into from
Closed

test: use Countdown in http test #17436

wants to merge 1 commit into from

Conversation

mithunsasidharan
Copy link
Contributor

refactored test case in test-http-response-multi-content-length to use countdown as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Dec 3, 2017
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11859/

@apapirovski
Copy link
Member

Nit: the commit title should be adjusted to be < 50 characters.

@mithunsasidharan mithunsasidharan changed the title test: refactored test case in test-http-response-multi-content-length to use countdown test: refactored test-http-response-multi-content-length to use countdown Dec 3, 2017
@mithunsasidharan
Copy link
Contributor Author

@apapirovski : Update the commit message. Kindly review the PR now. Thanks !

@apapirovski
Copy link
Member

The commit message still looks too long to me (70 chars or so). I would go with something like test: use Countdown in http test

@mithunsasidharan mithunsasidharan changed the title test: refactored test-http-response-multi-content-length to use countdown test: use Countdown in http test Dec 3, 2017
@mithunsasidharan
Copy link
Contributor Author

@apapirovski : I've updated the commit message. Kindly review the PR now. Thanks !

@apapirovski
Copy link
Member

Looks good, thanks!

@tniessen
Copy link
Member

tniessen commented Dec 5, 2017

Landed in 90b257e, thank you!

@tniessen tniessen closed this Dec 5, 2017
tniessen pushed a commit that referenced this pull request Dec 5, 2017
@mithunsasidharan @tniessen
test: use Countdown in http test
90b257e 
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: use Countdown in http test
5277156 
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan @MylesBorins
test: use Countdown in http test
85e6271 
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan @gibfahn
test: use Countdown in http test
8fc1969 
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan @gibfahn
test: use Countdown in http test
52e573d 
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan @gibfahn
test: use Countdown in http test
fddba18 
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@maclover7 maclover7 maclover7 approved these changes

@lpinca lpinca lpinca approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mithunsasidharan @apapirovski @tniessen @lpinca @maclover7 @mscdex @gibfahn @nodejs-github-bot