Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention node-test-pull-request-lite job #17513

Closed
wants to merge 2 commits into from
Closed

doc: mention node-test-pull-request-lite job #17513

wants to merge 2 commits into from

Conversation

maclover7
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc

@maclover7 maclover7 requested a review from Trott December 7, 2017 00:28
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 7, 2017
apapirovski
apapirovski approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Dec 7, 2017 •
edited
Loading

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

@maclover7
Copy link
Contributor Author

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

@vsemozhetbyt Hmm, interesting question. My initial thought is that yes, it would be okay, although this is probably something that would need a separate issue opened for more discussion.

Trott
Trott approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe instead of "quick fixes" say "trivial changes" or even "trivial doc-only changes"?

lpinca
lpinca approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @Trott's suggestion.

@maclover7
Copy link
Contributor Author

updated @Trott @lpinca

@Trott
Copy link
Member

Trott commented Dec 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/5/

(See what I did there?)

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
@maclover7
Copy link
Contributor Author

Landing...

@maclover7 maclover7 self-assigned this Dec 8, 2017
@maclover7
Copy link
Contributor Author

Landed in de3a7db

maclover7 added a commit to maclover7/node that referenced this pull request Dec 8, 2017
@maclover7
doc: mention node-test-pull-request-lite job
de3a7db 
PR-URL: nodejs#17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@maclover7 maclover7 closed this Dec 8, 2017
@maclover7 maclover7 deleted the jm-add-job branch December 8, 2017 14:39
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@maclover7 @MylesBorins
doc: mention node-test-pull-request-lite job
835cc23 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@maclover7 @MylesBorins
doc: mention node-test-pull-request-lite job
6aa6d41 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@maclover7 @gibfahn
doc: mention node-test-pull-request-lite job
ee52ce9 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@maclover7 @gibfahn
doc: mention node-test-pull-request-lite job
4035686 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@maclover7 @gibfahn
doc: mention node-test-pull-request-lite job
418ee1c 
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees

@maclover7 maclover7

Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@maclover7 @vsemozhetbyt @Trott @apapirovski @lpinca @cjihrig @addaleax @gibfahn @nodejs-github-bot