Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 5.6.0 #17535

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 5.6.0 #17535

wants to merge 1 commit into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Dec 7, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of Changes

Here it is! It's been a long time coming, what with conference season, vacations, and everyone getting sick, but I think folks have been expecting this one for a bit. This is another fairly sizeable release, as far as impact goes, and did include some refactoring, but it's been sitting in @next for a week and has gotten some use from folks, so we think it's ready to bump in Node!

The most important thing with this release is, probably, that npm now works with node@9 out of the box. Previously, y'all had floated a patch over 5.5.1, but this change integrates it directly. 🎉

Other changes of note to node folks:

  • npm/npm@66d18280c npm/npm#19104 Add new --node-options config to pass through a custom NODE_OPTIONS for lifecycle scripts. (@bmeck)
  • npm/npm@c930e98ad npm-lifecycle@2.0.0: npm's node-gyp is now included as part of an external library, npm-lifecycle, so any future PRs by Node folks to bump or adjust node-gyp versions should be made against https://github.com/npm/lifecycle instead. (@zkochan)
  • bc263c3fd #19054 Fully cross-platform package-lock.json. Installing a failing optional dependency on one platform no longer removes it from the dependency tree, meaning that package-lock.json should now be generated consistently across platforms! 🎉 (@iarna)
  • A whole slew of bugfixes, including some for platforms like Docker and Windows which should fix further issues.
Changelogs

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Dec 7, 2017
@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 7, 2017
@zkat zkat changed the base branch from master to v9.x-staging December 7, 2017 22:44
@MylesBorins MylesBorins self-requested a review December 8, 2017 04:04
@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11968/

evanlucas
evanlucas approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! Thanks @zkat!

Rubberstamp LGTM

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2017
@fishcharlie
Copy link

Any idea when this will make it into a Node.js release?

@BridgeAR
Copy link
Member

I am a bit confused about the first commit. Is it intentionally added here?

@zkat
Copy link
Contributor Author

zkat commented Dec 12, 2017

@BridgeAR oh weird. Lemme get rid of that right quick. I probably messed up the rebase (or the staging branch had that commit removed/rewritten)

@richardlau
Copy link
Member

Is there a reason this is targeted at v9.x-staging and not master?

@zkat
Copy link
Contributor Author

zkat commented Dec 12, 2017

@richardlau because node@10 is not yet supported by npm, and you're gonna get a big ugly warning that's gonna make the tests fail if you try.

addaleax pushed a commit to addaleax/node that referenced this pull request Dec 13, 2017
@zkat @addaleax
deps: upgrade npm to 5.6.0
7fda797 
PR-URL: nodejs#17535
Reviewed-By: Evan Lucas <evanlucas@me.com>
@addaleax addaleax added the v9.x label Dec 13, 2017
@bnoordhuis bnoordhuis mentioned this pull request Dec 13, 2017
Closed
@corvinrok
Copy link
Contributor

Will this also be considered for the 8.x line?

@BridgeAR
Copy link
Member

@zkat is there a nice way to get the tests to pass on Node.js v.10? Because it would be great to also have the newest npm version also on master. Maybe passing a flag that could make the test pass?

BridgeAR
BridgeAR approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

MylesBorins
MylesBorins approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins removed the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 20, 2017
MylesBorins pushed a commit that referenced this pull request Dec 20, 2017
@zkat @MylesBorins
deps: upgrade npm to 5.6.0
df94fa5 
PR-URL: #17535
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@zkat zkat restored the npm-5.6.0 branch December 21, 2017 22:11
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
gibfahn added a commit that referenced this pull request Jan 2, 2018
@gibfahn
2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
cfd8f94 
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)
gibfahn added a commit that referenced this pull request Jan 3, 2018
@gibfahn
2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
d6bf5d1 
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)
gibfahn added a commit that referenced this pull request Jan 3, 2018
@gibfahn
2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
ec9fb6d 
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins added a commit that referenced this pull request Jan 10, 2018
@MylesBorins
2019-01-10 Version 9.4.0 (Current)
074a2cb 
Notable change:

* async_hooks:
  - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
    API were documented. (Andreas Madsen)
    #16972
* deps:
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
  - upgrade npm to 5.6.0 (Kat Marchán)
    #17535
  - cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
    #16591
* events:
  - remove reaches into _events internals (Anatoli Papirovski)
    #17440
* http:
  - add rawPacket in err of `clientError` event (XadillaX)
    #17672
* http2:
  - implement maxSessionMemory (James M Snell)
    #17967
  - add initial support for originSet (James M Snell)
    #17935
  - add altsvc support (James M Snell)
    #17917
  - perf_hooks integration (James M Snell)
    #17906
* net:
  - remove Socket.prototype.write (Anna Henningsen)
    #17644
  - remove Socket.prototype.listen (Ruben Bridgewater)
    #13735
* repl:
  - show lexically scoped vars in tab completion (Michaël Zasso)
    #16591
* stream:
  - rm {writeable/readable}State.length (Calvin Metcalf)
    #12857
  - add flow and buffer properties to streams (Calvin Metcalf)
    #12855
* util:
  - allow wildcards in NODE_DEBUG variable (Tyler)
    #17609
* zlib:
  - add ArrayBuffer support (Jem Bezooyen)
    #16042
* Addedew collaborator**
  - [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
  - [danbev](https://github.com/danbev) Daniel Bevenius

PR-URL: #18069
MylesBorins added a commit that referenced this pull request Jan 10, 2018
@MylesBorins
2019-01-10 Version 9.4.0 (Current)
7aefa40 
Notable change:

* async_hooks:
  - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
    API were documented. (Andreas Madsen)
    #16972
* deps:
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
  - upgrade npm to 5.6.0 (Kat Marchán)
    #17535
  - cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
    #16591
* events:
  - remove reaches into _events internals (Anatoli Papirovski)
    #17440
* http:
  - add rawPacket in err of `clientError` event (XadillaX)
    #17672
* http2:
  - implement maxSessionMemory (James M Snell)
    #17967
  - add initial support for originSet (James M Snell)
    #17935
  - add altsvc support (James M Snell)
    #17917
  - perf_hooks integration (James M Snell)
    #17906
  - Refactoring and cleanup of Http2Session and Http2Stream destroy
    (James M Snell) #17406
* net:
  - remove Socket.prototype.write (Anna Henningsen)
    #17644
  - remove Socket.prototype.listen (Ruben Bridgewater)
    #13735
* repl:
  - show lexically scoped vars in tab completion (Michaël Zasso)
    #16591
* stream:
  - rm {writeable/readable}State.length (Calvin Metcalf)
    #12857
  - add flow and buffer properties to streams (Calvin Metcalf)
    #12855
* util:
  - allow wildcards in NODE_DEBUG variable (Tyler)
    #17609
* zlib:
  - add ArrayBuffer support (Jem Bezooyen)
    #16042
* Addedew collaborator**
  - [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
  - [danbev](https://github.com/danbev) Daniel Bevenius

PR-URL: #18069
MylesBorins added a commit that referenced this pull request Jan 10, 2018
@MylesBorins
2019-01-10 Version 9.4.0 (Current)
e688175 
Notable change:

* async_hooks:
  - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
    API were documented. (Andreas Madsen)
    #16972
* deps:
  - update nghttp2 to 1.29.0 (James M Snell)
    #17908
  - upgrade npm to 5.6.0 (Kat Marchán)
    #17535
  - cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
    #16591
* events:
  - remove reaches into _events internals (Anatoli Papirovski)
    #17440
* http:
  - add rawPacket in err of `clientError` event (XadillaX)
    #17672
* http2:
  - implement maxSessionMemory (James M Snell)
    #17967
  - add initial support for originSet (James M Snell)
    #17935
  - add altsvc support (James M Snell)
    #17917
  - perf_hooks integration (James M Snell)
    #17906
  - Refactoring and cleanup of Http2Session and Http2Stream destroy
    (James M Snell) #17406
* net:
  - remove Socket.prototype.write (Anna Henningsen)
    #17644
  - remove Socket.prototype.listen (Ruben Bridgewater)
    #13735
* repl:
  - show lexically scoped vars in tab completion (Michaël Zasso)
    #16591
* stream:
  - rm {writeable/readable}State.length (Calvin Metcalf)
    #12857
  - add flow and buffer properties to streams (Calvin Metcalf)
    #12855
* util:
  - allow wildcards in NODE_DEBUG variable (Tyler)
    #17609
* zlib:
  - add ArrayBuffer support (Jem Bezooyen)
    #16042
* Addedew collaborator**
  - [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
  - [danbev](https://github.com/danbev) Daniel Bevenius

PR-URL: #18069
MylesBorins added a commit that referenced this pull request Jan 19, 2018
@MylesBorins
deps: manually add 10.x support to npm
cbd6349 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: #17535
PR-URL: #17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@richardlau richardlau mentioned this pull request Feb 5, 2018
Closed
MylesBorins added a commit to FallenRiteMonk/node that referenced this pull request Apr 5, 2018
@MylesBorins
deps: manually add 10.x support to npm
8f15080 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins added a commit that referenced this pull request Apr 5, 2018
@MylesBorins
deps: manually add 10.x support to npm
55557ba 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: #17535
Backport-PR-URL: #19560
PR-URL: #17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins added a commit to MylesBorins/node that referenced this pull request Apr 5, 2018
@MylesBorins
deps: manually add 10.x support to npm
3527dc0 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins @MayaLekova
deps: manually add 10.x support to npm
b2f8a91 
Currently npm explicitly doesn't support 10.x and will fail on master.
This patch manually adds support for 10.x so that we can keep an up to
date version of npm on master.

refs: nodejs#17535
PR-URL: nodejs#17777
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@evanlucas evanlucas evanlucas approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@zkat @MylesBorins @fishcharlie @BridgeAR @richardlau @corvinrok @gibfahn @evanlucas @addaleax @nodejs-github-bot