Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: simplify and clarify FIPS text in BUILDING.md #17538

Closed
wants to merge 1 commit into from
Closed

doc: simplify and clarify FIPS text in BUILDING.md #17538

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 7, 2017

Fixes: #17536

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Dec 7, 2017
@Trott Trott requested a review from mhdawson December 7, 2017 22:51
@Trott Trott mentioned this pull request Dec 7, 2017
Closed
@Trott
Copy link
Member Author

Trott commented Dec 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/7/

mhdawson
mhdawson approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 8, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2017
@Trott
doc: simplify and clarify FIPS text in BUILDING.md
4426d75 
PR-URL: nodejs#17538
Fixes: nodejs#17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@Trott
Copy link
Member Author

Trott commented Dec 10, 2017

Landed in 4426d75.

@Trott Trott closed this Dec 10, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
doc: simplify and clarify FIPS text in BUILDING.md
30f5a26 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
doc: simplify and clarify FIPS text in BUILDING.md
a965dda 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
doc: simplify and clarify FIPS text in BUILDING.md
dcee5ed 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
doc: simplify and clarify FIPS text in BUILDING.md
8e4cb1b 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
doc: simplify and clarify FIPS text in BUILDING.md
0b45766 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
doc: simplify and clarify FIPS text in BUILDING.md
26e0fa8 
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@Trott Trott deleted the fips-building branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@maclover7 maclover7 maclover7 approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUILDING.md references p. 60 of a 40 page security policy document
7 participants
@Trott @lpinca @maclover7 @mhdawson @addaleax @gibfahn @nodejs-github-bot