-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove unused include node_crypto_clienthello #17546
Closed
danbev
wants to merge
2
commits into
nodejs:master
from
danbev:remove-unused-include-node_crypto_clienthello.h
Closed
src: remove unused include node_crypto_clienthello #17546
danbev
wants to merge
2
commits into
nodejs:master
from
danbev:remove-unused-include-node_crypto_clienthello.h
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the include of node.h which does not seem to be used.
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
labels
Dec 8, 2017
bnoordhuis
approved these changes
Dec 8, 2017
cjihrig
approved these changes
Dec 11, 2017
Landed in 7bb2cc4. |
danbev
added a commit
that referenced
this pull request
Dec 11, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the include of node.h which does not seem to be
used.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
crypto