Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net,src: refactor writeQueueSize tracking #17650

Closed
wants to merge 1 commit into from
Closed

net,src: refactor writeQueueSize tracking #17650

wants to merge 1 commit into from

Commits on Dec 18, 2017

  1. net,src: refactor writeQueueSize tracking 

    Currently, writeQueueSize is never used in C++ and barely
used within JS. Instead of constantly updating the value
on the JS object, create a getter that will retrieve the
most up-to-date value from C++.

For the vast majority of cases though, create a new prop
on Socket.prototype[kLastWriteQueueSize] using a Symbol.
Use this to track the current write size, entirely in
JS land.
    @apapirovski
    apapirovski committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    a99b447 View commit details
    Browse the repository at this point in the history