test: fix flaky test-benchmark-misc #17686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow zero results for short benchmark test.
Trott
added
benchmark
|
Sample failure without this change: https://ci.nodejs.org/job/node-test-commit-linux/14918/nodes=alpine35-container-x64/consoleText not ok 152 parallel/test-benchmark-misc
---
duration_ms: 4.974
severity: fail
stack: |-
misc/console.js
misc/console.js n=1 concat=0 method="": 275.9450427852789
misc/freelist.js
misc/freelist.js n=1: 491.6860800720615
misc/function_call
misc/object-property-bench.js
misc/function_call.js Binding failed to load
/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:202
throw new Error('insufficient clock precision for short benchmark');
^
Error: insufficient clock precision for short benchmark
at Benchmark.end (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:202:13)
at runProperty (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/misc/object-property-bench.js:19:9)
at main (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/misc/object-property-bench.js:69:7)
at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:34:28)
at process._tickCallback (internal/process/next_tick.js:150:11)
at Function.Module.runMain (module.js:703:11)
at startup (bootstrap_node.js:195:16)
at bootstrap_node.js:646:3
assert.js:42
throw new errors.AssertionError({
^
AssertionError [ERR_ASSERTION]: 1 strictEqual 0
at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/test/common/benchmark.js:25:12)
at ChildProcess.emit (events.js:126:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
... |
cjihrig
approved these changes
Dec 14, 2017
apapirovski
approved these changes
Dec 14, 2017
|
LinuxONE build failure unrelated. Re-run: https://ci.nodejs.org/job/node-test-commit-linuxone/11172/ |
jasnell
approved these changes
Dec 14, 2017
|
Unrelated build failures on linux. Re-running: https://ci.nodejs.org/job/node-test-commit-linux/14967/ |
|
Windows build failures. Re-run: https://ci.nodejs.org/job/node-test-binary-windows/13640/ |
|
CI was having general issues yesterday. Seems to be cleared up. So one more time... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2017
Allow zero results for short benchmark test. PR-URL: nodejs#17686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in eecea2e |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
Allow zero results for short benchmark test. PR-URL: #17686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2018
Allow zero results for short benchmark test. PR-URL: #17686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
Allow zero results for short benchmark test. PR-URL: #17686 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow zero results for short benchmark test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark