Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove redundant JSStream::DoAfterWrite #17713

Closed
wants to merge 1 commit into from
Closed

src: remove redundant JSStream::DoAfterWrite #17713

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Finish<WriteWrap> already does the same thing and is called immediately afterwards anyway.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/js_stream

@addaleax
src: remove redundant JSStream::DoAfterWrite
d1d298b 
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 16, 2017
@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 16, 2017
bnoordhuis
bnoordhuis approved these changes Dec 16, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/14890/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2017
@addaleax
Copy link
Member Author

addaleax commented Dec 21, 2017 •
edited
Loading

Landed in 901e9a1  

@addaleax addaleax closed this Dec 21, 2017
@addaleax addaleax deleted the no-do-after-write branch December 21, 2017 19:56
addaleax added a commit that referenced this pull request Dec 21, 2017
@addaleax
src: remove redundant JSStream::DoAfterWrite
901e9a1 
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@addaleax @MylesBorins
src: remove redundant JSStream::DoAfterWrite
0a9ecfc 
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@addaleax @MylesBorins
src: remove redundant JSStream::DoAfterWrite
110e74c 
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@addaleax @MylesBorins
src: remove redundant JSStream::DoAfterWrite
2aa75a1 
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@gibfahn
Copy link
Member

gibfahn commented Jan 24, 2018

Should this go back to 6.x or 8.x? If so please raise a backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @gibfahn @apapirovski @bnoordhuis @jasnell @cjihrig @nodejs-github-bot