Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: convert Http2Settings to an AsyncWrap #17763

Closed
wants to merge 1 commit into from
Closed

http2: convert Http2Settings to an AsyncWrap #17763

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 19, 2017

Make Http2Settings an AsyncWrap.

Refs: #17746

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 19, 2017
@jasnell jasnell mentioned this pull request Dec 19, 2017
Closed
11 tasks
@jasnell
Copy link
Member Author

jasnell commented Dec 21, 2017

ping @mcollina @nodejs/http2

@jasnell
Copy link
Member Author

jasnell commented Dec 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12251/

mcollina
mcollina approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina reviewed Dec 21, 2017
View reviewed changes
lib/internal/http2/core.js Outdated
cb(err, this.localSettings, duration);
}
if (ack)
this.emit('localSettings', this.localSettings);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at least so a debug if ack is null.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reworked the entire function a bit to clean it up more and add the debug output.

@jasnell
Copy link
Member Author

jasnell commented Dec 22, 2017

New CI: https://ci.nodejs.org/job/node-test-pull-request/12263/

@jasnell
Copy link
Member Author

jasnell commented Dec 22, 2017

Try again: https://ci.nodejs.org/job/node-test-pull-request/12264/

@jasnell
Copy link
Member Author

jasnell commented Dec 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12268/

@jasnell
Copy link
Member Author

jasnell commented Dec 22, 2017

CI is good

jasnell added a commit that referenced this pull request Dec 22, 2017
@jasnell
http2: convert Http2Settings to an AsyncWrap
bbaea12 
PR-URL: #17763
Refs: #17746
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Dec 22, 2017

Landed in bbaea12

@jasnell jasnell closed this Dec 22, 2017
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
http2: convert Http2Settings to an AsyncWrap
293c2f9 
PR-URL: nodejs#17763
Refs: nodejs#17746
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
http2: convert Http2Settings to an AsyncWrap
098edcb 
Backport-PR-URL: #18050
PR-URL: #17763
Refs: #17746
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@jasnell @MylesBorins
http2: convert Http2Settings to an AsyncWrap
3a6b2ad 
Backport-PR-URL: #18050
PR-URL: #17763
Refs: #17746
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
http2: convert Http2Settings to an AsyncWrap
f68325c 
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17763
Refs: nodejs#17746
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
http2: convert Http2Settings to an AsyncWrap
0463221 
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17763
Refs: #17746
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @mcollina @MylesBorins @nodejs-github-bot