Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove duplicate words in API docs #17937

Closed
wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jan 1, 2018

Found using a simple regex.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Sorry, something went wrong.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 1, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 1, 2018
@tniessen
Copy link
Member Author

tniessen commented Jan 1, 2018

@tniessen
Copy link
Member Author

tniessen commented Jan 1, 2018

Landed in d74a1ed.

@tniessen tniessen closed this Jan 1, 2018
tniessen added a commit that referenced this pull request Jan 1, 2018
PR-URL: #17937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@maclover7
Copy link
Contributor

@tniessen Would you be interested in converting the regex into a linter rule that could be run as part of make lint-md?

@tniessen
Copy link
Member Author

tniessen commented Jan 1, 2018

@maclover7 I don't think it is possible to generalize it (be be is a valid hexadecimal sequence but usually incorrect when used as words, "a can can help" is a valid English sentence, etc.). Even if it is possible, I don't think it is worth the trouble.

MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
PR-URL: #17937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
PR-URL: #17937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
PR-URL: #17937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
PR-URL: #17937
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants