lib,test: fix spelling in comments #18018

tniessen · 2018-01-06T18:58:39Z

Various spelling fixes. I am not sure whether to split this into multiple commits.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

lib, test

maclover7

LGTM

Personally, I'm fine with one large commit.

apapirovski

SGTM! 👍

apapirovski · 2018-01-06T19:19:35Z

test/parallel/test-http-agent-keepalive.js

@@ -102,7 +102,7 @@ function remoteClose() {
 }

 function remoteError() {
-  // remove server will destroy ths socket
+  // remove server will destroy the socket


I think "remove" here is supposed to be "remote"?

Ahhh yeah sure, thanks!

apapirovski · 2018-01-06T19:20:39Z

test/parallel/test-http-extra-response.js

@@ -51,7 +51,7 @@ const server = net.createServer(function(socket) {

    if (postBody.includes('\r\n')) {
      socket.write(fullResponse);
-      // omg, I wrote the response twice, what a terrible HTTP server I am.
+      // I wrote the response twice, what a terrible HTTP server I am.


I don't know if this comment adds much in general, to be honest. I would be in favour of taking it out.

apapirovski · 2018-01-06T19:23:11Z

test/parallel/test-promises-unhandled-rejections.js

@@ -293,7 +293,7 @@ asyncTest('While inside setImmediate, catching a rejected promise derived ' +
  });
 });

-// State adapation tests
+// State adaption tests


I don't really understand what this comment is saying (before or after). :( I think the tests describe what they do well enough.

(If we are to keep it, I would prefer to use the more common version "adaptation".)

I don't fully understand that test either, I went with "adaptation" for now. If someone knows what's going on here, we might actually remove it.

tniessen · 2018-01-06T19:42:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/12438/

jasnell · 2018-01-09T23:30:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/12472/

tniessen · 2018-01-10T23:07:21Z

Seems like CI was interrupted, new CI: https://ci.nodejs.org/job/node-test-pull-request/12494/

PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

tniessen · 2018-01-11T15:51:02Z

Landed in e890344, ba07699.

PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

MylesBorins · 2018-02-27T05:30:17Z

Should this be backported to v6.x-staging or v8.x-staging?? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

PR-URL: nodejs#18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

Backport-PR-URL: #19118 PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

Backport-PR-URL: #19118 PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

Backport-PR-URL: #19118 PR-URL: #18018 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jan 6, 2018

maclover7 approved these changes Jan 6, 2018

View reviewed changes

tniessen changed the title ~~test: fix spelling in test case comments~~ lib,test: fix spelling in test case comments Jan 6, 2018

tniessen changed the title ~~lib,test: fix spelling in test case comments~~ lib,test: fix spelling in comments Jan 6, 2018

apapirovski approved these changes Jan 6, 2018

View reviewed changes

starkwang approved these changes Jan 7, 2018

View reviewed changes

lpinca approved these changes Jan 7, 2018

View reviewed changes

tniessen added 3 commits January 7, 2018 16:02

test: fix spelling in test case comments

0374f6c

lib: fix spelling in comments

849676d

fixup! test: fix spelling in test case comments

8fcc84d

tniessen force-pushed the fix-spelling-in-tests branch from d984a90 to 8fcc84d Compare January 7, 2018 15:03

jasnell approved these changes Jan 7, 2018

View reviewed changes

cjihrig approved these changes Jan 7, 2018

View reviewed changes

hiroppy approved these changes Jan 8, 2018

View reviewed changes

tniessen closed this Jan 11, 2018

AndreasMadsen removed the async_hooks Issues and PRs related to the async hooks subsystem. label Jan 16, 2018

evanlucas mentioned this pull request Jan 30, 2018

v9.5.0 release proposal #18464

Merged

MylesBorins added backport-requested-v6.x labels Feb 27, 2018

tniessen mentioned this pull request Mar 4, 2018

(v8.x backport) lib,test: fix spelling in comments #19118

Closed

tniessen mentioned this pull request Mar 4, 2018

(v6.x backport) lib,test: fix spelling in comments #19121

Closed

MylesBorins added land-on-v8.x and removed backport-requested-v8.x labels Mar 21, 2018

MylesBorins mentioned this pull request Apr 13, 2018

v6.14.2 proposal #19996

Merged

MylesBorins mentioned this pull request May 2, 2018

v8.11.2 proposal #20478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib,test: fix spelling in comments #18018

lib,test: fix spelling in comments #18018

tniessen commented Jan 6, 2018 •

edited

Loading

maclover7 left a comment

apapirovski left a comment

apapirovski Jan 6, 2018

tniessen Jan 6, 2018

apapirovski Jan 6, 2018

apapirovski Jan 6, 2018

tniessen Jan 6, 2018

tniessen commented Jan 6, 2018

jasnell commented Jan 9, 2018

tniessen commented Jan 10, 2018

tniessen commented Jan 11, 2018

MylesBorins commented Feb 27, 2018

lib,test: fix spelling in comments #18018

lib,test: fix spelling in comments #18018

Conversation

tniessen commented Jan 6, 2018 • edited Loading

Checklist

Affected core subsystem(s)

maclover7 left a comment

Choose a reason for hiding this comment

apapirovski left a comment

Choose a reason for hiding this comment

apapirovski Jan 6, 2018

Choose a reason for hiding this comment

tniessen Jan 6, 2018

Choose a reason for hiding this comment

apapirovski Jan 6, 2018

Choose a reason for hiding this comment

apapirovski Jan 6, 2018

Choose a reason for hiding this comment

tniessen Jan 6, 2018

Choose a reason for hiding this comment

tniessen commented Jan 6, 2018

jasnell commented Jan 9, 2018

tniessen commented Jan 10, 2018

tniessen commented Jan 11, 2018

MylesBorins commented Feb 27, 2018

tniessen commented Jan 6, 2018 •

edited

Loading