Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor HasWriteQueue() away #18019

Closed
wants to merge 3 commits into from
Closed

src: refactor HasWriteQueue() away #18019

wants to merge 3 commits into from

Commits on Jan 10, 2018

  1. process: use more direct sync I/O for stdio 

    This avoids routing writes through the full LibuvStreamWrap
write machinery. In particular, it enables the next commit,
because otherwise the callback passed to `_write()`
would not be called synchronously for pipes on Windows
(because the latter does not support `uv_try_write()`,
even for blocking I/O).
    @addaleax
    addaleax committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    4b0fd7a View commit details
    Browse the repository at this point in the history

  2. src: remove HasWriteQueue() 

    Tests are passing without it, and this otherwise makes the
code harder to reason about because the `async` flag on the
write request object would not be set even though the callback
would still be pending.
    @addaleax
    addaleax committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    fad18b4 View commit details
    Browse the repository at this point in the history

  3. src: use DoTryWrite() for not-all-Buffer writev()s too

    @addaleax
    addaleax committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    72ff460 View commit details
    Browse the repository at this point in the history