Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update pushStream docs to use err first #18088

Closed
wants to merge 2 commits into from
Closed

doc: update pushStream docs to use err first #18088

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 10, 2018

Refs: #17406 (comment)

/cc @mcollina

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, doc

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 10, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jan 10, 2018
mcollina
mcollina approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

👍 for fast track

@Flarna
Copy link
Member

Flarna commented Jan 10, 2018

If you are on the way to fix http2 docs as result of #17406 you could also change the call to req.rstStream in sample code of http2stream.setTimeout (see https://nodejs.org/dist/latest-v9.x/docs/api/http2.html#http2_http2stream_settimeout_msecs_callback)

@jasnell jasnell force-pushed the http2-fix-push-stream-docs branch from 69a4d5f to 17ee4c5 Compare January 11, 2018 18:04
@jasnell
Copy link
Member Author

jasnell commented Jan 11, 2018

@Flarna ... great catch... updated!

@jasnell
Copy link
Member Author

jasnell commented Jan 11, 2018

CI Lint: https://ci.nodejs.org/job/node-test-linter/15104/

jasnell added a commit that referenced this pull request Jan 11, 2018
@jasnell
doc: update pushStream docs to use err first
078b7a2 
Refs: #17406 (comment)

PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request Jan 11, 2018
@jasnell
doc: fix s/rstStream/close in example
47a2822 
PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 11, 2018

Landed in 078b7a2 and 47a2822

@jasnell jasnell closed this Jan 11, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@jasnell @evanlucas
doc: update pushStream docs to use err first
1c81a05 
Refs: #17406 (comment)

PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@jasnell @evanlucas
doc: fix s/rstStream/close in example
30e2221 
PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins
Copy link
Contributor

is this accurate for the current 8.x implementation?

kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
doc: update pushStream docs to use err first
3d13a16 
Refs: nodejs#17406 (comment)

PR-URL: nodejs#18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
doc: fix s/rstStream/close in example
de1e52e 
PR-URL: nodejs#18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
doc: update pushStream docs to use err first
d9d0d0e 
Refs: #17406 (comment)

Backport-PR-URL: #20456
PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
doc: fix s/rstStream/close in example
88babd5 
Backport-PR-URL: #20456
PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jasnell @mcollina @Flarna @MylesBorins @danbev @addaleax @lpinca @BethGriggs @nodejs-github-bot