Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v9.x backport) errors: remove ERR_OUTOFMEMORY #18099

Closed
wants to merge 1 commit into from
Closed

(v9.x backport) errors: remove ERR_OUTOFMEMORY #18099

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Backport of #17877 to v9.x.

@tniessen
errors: remove ERR_OUTOFMEMORY
7fa5a6e 
PR-URL: nodejs#17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen tniessen requested a review from MylesBorins January 11, 2018 11:47
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. v9.x labels Jan 11, 2018
evanlucas
evanlucas approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/12534/

evanlucas pushed a commit that referenced this pull request Jan 17, 2018
@tniessen @evanlucas
errors: remove ERR_OUTOFMEMORY
df8cb40 
Backport-PR-URL: #18099
PR-URL: #17877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@evanlucas
Copy link
Contributor

Landed in df8cb40. Thanks!

@evanlucas evanlucas closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @evanlucas @jasnell @cjihrig @nodejs-github-bot