Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: capitalize non-primitive types #18111

Closed
wants to merge 1 commit into from
Closed

doc: capitalize non-primitive types #18111

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 12, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 12, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 12, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/83/

@vsemozhetbyt
Copy link
Contributor Author

Landed in c3fde98

@vsemozhetbyt vsemozhetbyt deleted the doc-cap-obj-types branch January 12, 2018 00:52
vsemozhetbyt added a commit that referenced this pull request Jan 12, 2018
@vsemozhetbyt
doc: capitalize non-primitive types
c3fde98 
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas
Copy link
Contributor

This is not landing cleanly on v9.x-staging. If you would like to see this land in v9.x, can you please submit a backport PR? Thanks!

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jan 30, 2018
Closed
3 tasks
@vsemozhetbyt
Copy link
Contributor Author

v9.x backport: #18465

MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
6b1a40e 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
be1d3b8 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
325dc27 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
e84e9db 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsemozhetbyt @evanlucas @ChALkeR @jasnell @cjihrig @MylesBorins @nodejs-github-bot