Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in napi test #18148

Closed
wants to merge 2 commits into from
Closed

Fixed typos in napi test #18148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64c8fff
Fixed typos in napi test
furstenheim Jan 14, 2018
73d212c
Fix typo in test symbol
furstenheim Jan 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/addons-napi/test_symbol/test_symbol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ napi_value Test(napi_env env, napi_callback_info info) {
NAPI_CALL(env, napi_typeof(env, args[0], &valuetype));

NAPI_ASSERT(env, valuetype == napi_symbol,
"Wrong type of argments. Expects a symbol.");
"Wrong type of arguments. Expects a symbol.");

char buffer[128];
size_t buffer_size = 128;
Expand Down
14 changes: 7 additions & 7 deletions test/addons-napi/test_typedarray/test_typedarray.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ napi_value Multiply(napi_env env, napi_callback_info info) {
NAPI_CALL(env, napi_typeof(env, args[0], &valuetype0));

NAPI_ASSERT(env, valuetype0 == napi_object,
"Wrong type of argments. Expects a typed array as first argument.");
"Wrong type of arguments. Expects a typed array as first argument.");

napi_value input_array = args[0];
bool is_typedarray;
NAPI_CALL(env, napi_is_typedarray(env, input_array, &is_typedarray));

NAPI_ASSERT(env, is_typedarray,
"Wrong type of argments. Expects a typed array as first argument.");
"Wrong type of arguments. Expects a typed array as first argument.");

napi_valuetype valuetype1;
NAPI_CALL(env, napi_typeof(env, args[1], &valuetype1));

NAPI_ASSERT(env, valuetype1 == napi_number,
"Wrong type of argments. Expects a number as second argument.");
"Wrong type of arguments. Expects a number as second argument.");

double multiplier;
NAPI_CALL(env, napi_get_value_double(env, args[1], &multiplier));
Expand Down Expand Up @@ -108,26 +108,26 @@ napi_value CreateTypedArray(napi_env env, napi_callback_info info) {
NAPI_CALL(env, napi_typeof(env, input_array, &valuetype0));

NAPI_ASSERT(env, valuetype0 == napi_object,
"Wrong type of argments. Expects a typed array as first argument.");
"Wrong type of arguments. Expects a typed array as first argument.");

bool is_typedarray;
NAPI_CALL(env, napi_is_typedarray(env, input_array, &is_typedarray));

NAPI_ASSERT(env, is_typedarray,
"Wrong type of argments. Expects a typed array as first argument.");
"Wrong type of arguments. Expects a typed array as first argument.");

napi_valuetype valuetype1;
napi_value input_buffer = args[1];
NAPI_CALL(env, napi_typeof(env, input_buffer, &valuetype1));

NAPI_ASSERT(env, valuetype1 == napi_object,
"Wrong type of argments. Expects an array buffer as second argument.");
"Wrong type of arguments. Expects an array buffer as second argument.");

bool is_arraybuffer;
NAPI_CALL(env, napi_is_arraybuffer(env, input_buffer, &is_arraybuffer));

NAPI_ASSERT(env, is_arraybuffer,
"Wrong type of argments. Expects an array buffer as second argument.");
"Wrong type of arguments. Expects an array buffer as second argument.");

napi_typedarray_type type;
napi_value in_array_buffer;
Expand Down