Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of null to assert.ifError #18236

Closed
wants to merge 1 commit into from
Closed

Add example of null to assert.ifError #18236

wants to merge 1 commit into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Jan 18, 2018

This is useful when testing the error argument in callbacks.

— Assert | Node.js v9.4.0 Documentation

error argument would be null or Error.
I think need to add example case of null to help understanding assert.ifError.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jan 18, 2018
@targos
Copy link
Member

targos commented Jan 20, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/104/

@targos
Copy link
Member

targos commented Jan 20, 2018

Commit message nit: start with a lowercase after the subsystem.

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 21, 2018
@BridgeAR
Copy link
Member

Landed in 08ada72

@BridgeAR BridgeAR closed this Jan 21, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 21, 2018
@Leko @BridgeAR
doc: Add example of null to assert.ifError
08ada72 
PR-URL: nodejs#18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Leko Leko deleted the add-example-assert_ifError branch January 22, 2018 05:53
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@Leko @evanlucas
doc: Add example of null to assert.ifError
4b6297a 
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@Leko @evanlucas
doc: Add example of null to assert.ifError
01599e2 
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@Leko @MylesBorins
doc: Add example of null to assert.ifError
1e8d120 
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@Leko @MylesBorins
doc: Add example of null to assert.ifError
d554b8a 
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Feb 27, 2018
Closed
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Leko @MayaLekova
doc: Add example of null to assert.ifError
5ac5a7a 
PR-URL: nodejs#18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Leko @targos @BridgeAR @jasnell @addaleax @cjihrig @MylesBorins @nodejs-github-bot