Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use PBKDF2 in text #18279

Closed
wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

PBKDF2 should be spelled in upper-case letters when used in text, see RFC 2898 and relevant NIST documents.

Checklist
Affected core subsystem(s)

doc

Use upper case variant in text in compliance with RFC 2898.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jan 21, 2018
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 21, 2018
@tniessen
Copy link
Member Author

@tniessen
Copy link
Member Author

Landed in a65b0b9.

@tniessen tniessen closed this Jan 22, 2018
tniessen added a commit that referenced this pull request Jan 22, 2018
Use upper case variant in text in compliance with RFC 2898.

PR-URL: #18279
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
Use upper case variant in text in compliance with RFC 2898.

PR-URL: #18279
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
Use upper case variant in text in compliance with RFC 2898.

PR-URL: #18279
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
Use upper case variant in text in compliance with RFC 2898.

PR-URL: #18279
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Feb 27, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Use upper case variant in text in compliance with RFC 2898.

PR-URL: nodejs#18279
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants