Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adds tests for vm invalid arguments #18282

Closed
wants to merge 1 commit into from
Closed

test: adds tests for vm invalid arguments #18282

wants to merge 1 commit into from

Conversation

gillesdemey
Copy link
Contributor

@gillesdemey gillesdemey commented Jan 21, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

vm

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 21, 2018
cjihrig
cjihrig approved these changes Jan 21, 2018
View reviewed changes
test/parallel/test-vm-basic.js
@@ -69,3 +69,56 @@ assert.strictEqual(result, 'undefined');
const sandbox3 = {};
const context2 = vm.createContext(sandbox3);
assert.strictEqual(sandbox3, context2);

// Test 6: invalid arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't be opposed to a follow up PR that removes these "Test n:" comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went with what was already there 😅

@starkwang
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12795/

@starkwang
Copy link
Contributor

Landed in 7f6a3ba

@starkwang starkwang closed this Jan 30, 2018
starkwang pushed a commit that referenced this pull request Jan 30, 2018
@gillesdemey @starkwang
test: adds tests for vm invalid arguments
7f6a3ba 
PR-URL: #18282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@gillesdemey @evanlucas
test: adds tests for vm invalid arguments
117b20e 
PR-URL: #18282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gillesdemey gillesdemey deleted the additional-vm-tests branch January 31, 2018 11:17
@MylesBorins
Copy link
Contributor

This fails on 8.x (I don't think it applies to 6.x)

Path: parallel/test-vm-basic
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: Missing expected exception (innerFn).
    at innerThrows (assert.js:646:7)
    at Function.throws (assert.js:662:3)
    at Object.expectsError (/Users/mborins/code/node/v8.x/test/common/index.js:783:12)
    at Object.<anonymous> (/Users/mborins/code/node/v8.x/test/parallel/test-vm-basic.js:74:8)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@gillesdemey @MayaLekova
test: adds tests for vm invalid arguments
f802f85 
PR-URL: nodejs#18282
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

ping re: failure on 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@starkwang starkwang starkwang approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gillesdemey @starkwang @MylesBorins @jasnell @lpinca @cjihrig @nodejs-github-bot