Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: backport 76c3ac5 from upstream #18298

Merged
merged 1 commit into from
Jan 24, 2018

Commits on Jan 24, 2018

  1. deps: V8: backport 76c3ac5 from upstream

    This fixes a bug in the CPU profiler where some ticks were attributed
    to the wrong file.
    
    Original commit message:
      [cpu-profiler] Fix script name when recording inlining info
    
      Use the script name from the shared function info to create an
      inline entry. Otherwise functions are attributed to the wrong file
      in the CpuProfileNode.
    
      See googleapis/cloud-profiler-nodejs#89
    
      Bug: v8:7203, v8:7241
      Change-Id: I8ea31943741770e6611275a9c93375922b934547
      Reviewed-on: https://chromium-review.googlesource.com/848093
      Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
      Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
      Cr-Commit-Position: refs/heads/master@{nodejs#50339}
    
    Refs: v8/v8@76c3ac5
    PR-URL: nodejs#18298
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    ofrobots committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    00687fb View commit details
    Browse the repository at this point in the history