Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: enable dynamic import flag for esmodules #18387

Closed
wants to merge 3 commits into from
Closed

module: enable dynamic import flag for esmodules #18387

wants to merge 3 commits into from

Commits on Jan 31, 2018

  1. module: enable dynamic import flag for esmodules 

    currently if you want to use dynamic import you must use both the
`--experimental-modules` and the `--harmony-dynamic-imports` flags.
Chrome is currently shipping dynamic import unflagged, the flag
only remains in V8 to guard embedders who have not set the appropriate
callback from throwing an unhandled rejection when the feature is used.

As such it is reasonable to enable the flag by default for
`--experimental-modules`
    @MylesBorins
    MylesBorins committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    8fee4ae View commit details
    Browse the repository at this point in the history

  2. fixup docs

    @MylesBorins
    MylesBorins committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    f1183ac View commit details
    Browse the repository at this point in the history

  3. fixup one more doc tweak

    @MylesBorins
    MylesBorins committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    6edbfde View commit details
    Browse the repository at this point in the history