Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix manpage warnings #18440

Closed
wants to merge 1 commit into from
Closed

doc: fix manpage warnings #18440

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

@silverwind silverwind commented Jan 29, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
Affected core subsystem(s)

doc

Fixes: #18434 which was introduced in 594b5d7. The textual output is the same for me, before and after this fix:

node [options] [v8 options] [script.js | -e "script" | - ] [--] [arguments]

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 29, 2018
@silverwind silverwind mentioned this pull request Jan 29, 2018
Closed
@silverwind silverwind removed the doc Issues and PRs related to the documentations. label Jan 29, 2018
@silverwind silverwind mentioned this pull request Jan 29, 2018
Closed
4 tasks
@silverwind silverwind added the doc Issues and PRs related to the documentations. label Jan 29, 2018
@silverwind
Copy link
Contributor Author

Thanks, landed in e56189e.

@silverwind silverwind closed this Jan 30, 2018
@silverwind silverwind deleted the fix-man-warnings branch January 30, 2018 17:52
silverwind referenced this pull request Jan 30, 2018
@silverwind
doc: fix manpage warnings
e56189e 
Fixes: #18434
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins referenced this pull request Mar 20, 2018
@silverwind @MylesBorins
doc: fix manpage warnings
b76e111 
Fixes: #18434
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

man node produces warnings on macOS
7 participants
@silverwind @bnoordhuis @danbev @jasnell @Fishrock123 @cjihrig @nodejs-github-bot