-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: linkify missing types #18444
Closed
Closed
doc: linkify missing types #18444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, alphabetize all types in type-parser.js and fix some nits in type formats.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
tools
Issues and PRs related to the tools directory.
labels
Jan 30, 2018
I cannot understand what is wrong with linter job( |
@vsemozhetbyt not your fault, see #18445 |
lpinca
approved these changes
Jan 30, 2018
jasnell
approved these changes
Jan 31, 2018
Landed in fd3a0cf |
vsemozhetbyt
added a commit
that referenced
this pull request
Feb 1, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Should this be backported to |
3 tasks
v8 backport: #19498 |
3 tasks
v6.x backport: #19500 |
Merged
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: nodejs#18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18601 Refs: nodejs#18407 Refs: nodejs#18444 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc, tools
Also, alphabetize all types in
type-parser.js
and fix some nits in type formats.Notes:
Custom types in
type-parser.js
were already grouped by module/subsystem, ASCII order being set inside each group.I am not sure about 2 types:
this
(is it OK to link in this way?) andAsyncHook
(we have no class chapter in the doc, so I've linked to theasync_hooks.createHook()
function which creates an instance; please, propose a better solution).These types have been added (the rest of non-linkified types were just fixed according to the already available types):