Revert "src: add getopt option parser" #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanlucas want to try fixing before reverting? |
|
Working on it now. Just wanted to go ahead and open the revert PR. |
|
@Fishrock123 #1864 includes a fix. |
mscdex
added
the
c++
|
Rubber-stamp LGTM. |
This reverts commit c0e7bf2. There are a few edge cases that can cause a crash and need to be properly handled. PR-URL: nodejs#1862 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 5b6f575. Thanks |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
This reverts commit c0e7bf2. There are a few edge cases that can cause a crash and need to be properly handled. PR-URL: nodejs/node#1862 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@evanlucas do you think you'll have time to pick this back up at some point? |
|
had actually just started working on it again yesterday :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c0e7bf2.
There are a few edge cases that can cause a crash
and need to be properly handled.
Example:
node -ieApologies for not catching this before merging.