Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: why we use try-finally over try-catch #18711

Closed
wants to merge 3 commits into from
Closed

docs: why we use try-finally over try-catch #18711

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c39cbd2
Use catch over finally
oliviertassinari Feb 11, 2018
e36c708
no silence
oliviertassinari Feb 11, 2018
c896eb3
;
oliviertassinari Feb 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,14 +513,11 @@ Module._load = function(request, parent, isMain) {
};

function tryModuleLoad(module, filename) {
var threw = true;
try {
module.load(filename);
threw = false;
} finally {
if (threw) {
delete Module._cache[filename];
}
} catch (err) {
delete Module._cache[filename];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This silently suppresses the error. You need to throw err.

throw err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing semicolon.

}
}

Expand Down