Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update crypo Certficate class. #18721

Closed
wants to merge 1 commit into from
Closed

doc: update crypo Certficate class. #18721

wants to merge 1 commit into from

Conversation

antoine-amara
Copy link
Contributor

@antoine-amara antoine-amara commented Feb 11, 2018 •
edited
Loading

update the dead link to documentation.
add a link to mozilla developper documentation because
W3C delete the reference to this element.

add a note to inform element is deprecated since HTML 5.2.

Fixes: #18662

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 11, 2018
vsemozhetbyt
vsemozhetbyt reviewed Feb 12, 2018
View reviewed changes
doc/api/crypto.md Outdated
Netscape and now specified formally as part of [HTML5's `keygen` element][].
Netscape and was specified formally as part of [HTML5's `keygen` element][].

Note `<keygen>` was deprecated since [HTML 5.2][] and new project should'nt use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits:
"Note" -> "Note that" (with rewrapping within 80 characters).
"should'nt" -> "shouldn't".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer "should not" to make it a bit more formal.

vsemozhetbyt
vsemozhetbyt reviewed Feb 12, 2018
View reviewed changes
doc/api/crypto.md Outdated
@@ -2469,7 +2472,8 @@ the `crypto`, `tls`, and `https` modules and are generally specific to OpenSSL.
[`verify.verify()`]: #crypto_verify_verify_object_signature_signatureformat
[Caveats]: #crypto_support_for_weak_or_compromised_algorithms
[Crypto Constants]: #crypto_crypto_constants_1
[HTML5's `keygen` element]: https://www.w3.org/TR/html5/forms.html#the-keygen-element
[HTML5's `keygen` element]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen
[HTML 5.2]: https://www.w3.org/TR/html52/changes.html#features-removed
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Feb 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it seems this should go before [HTML5's `keygen` element] ASCII-wise.

@vsemozhetbyt
Copy link
Contributor

cc @nodejs/crypto

@antoine-amara antoine-amara force-pushed the add-info-and-new-link-crypto-doc-#18662 branch from a069df8 to c701271 Compare February 12, 2018 20:53
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/168/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 13, 2018
Trott
Trott reviewed Feb 14, 2018
View reviewed changes
doc/api/crypto.md Outdated
Netscape and now specified formally as part of [HTML5's `keygen` element][].
Netscape and was specified formally as part of [HTML5's `keygen` element][].

Note that `<keygen>` was deprecated since [HTML 5.2][] and new project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: was -> is and project -> projects

@antoine-amara
doc: update crypo Certficate class.
59379d3 
update the dead link to <keygen> documentation.
add a link to mozilla developper documentation because
W3C delete the reference to this element.

add a note to inform <keygen> element is deprecated since HTML 5.2.

Fixes: nodejs#18662
@antoine-amara antoine-amara force-pushed the add-info-and-new-link-crypto-doc-#18662 branch from c701271 to 59379d3 Compare February 14, 2018 08:49
@vsemozhetbyt
Copy link
Contributor

CI-lite 2: https://ci.nodejs.org/job/node-test-pull-request-lite/171/

vsemozhetbyt pushed a commit that referenced this pull request Feb 14, 2018
@antoine-amara @vsemozhetbyt
doc: update crypo Certficate class.
138bdf6 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 138bdf6

Thank you!

@vsemozhetbyt vsemozhetbyt mentioned this pull request Feb 14, 2018
Closed
priyank-p added a commit to nodejs/node-core-utils that referenced this pull request Feb 17, 2018
@priyank-p
pr_summary: warn if we can't fetch author's name and email
8b40a72 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: #180
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
67c1811 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
9bec493 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@antoine-amara @MayaLekova
doc: update crypo Certficate class.
fcd6cb5 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: nodejs#18721
Fixes: nodejs#18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
b01e470 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
824fb0e 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
48ab389 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@antoine-amara @MylesBorins
doc: update crypo Certficate class.
9c52231 
Update the dead link to <keygen> documentation.
Add a link to mozilla developper documentation because
W3C deleted the reference to this element.

Add a note to inform <keygen> element is deprecated since HTML 5.2.

PR-URL: #18721
Fixes: #18662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this pull request Nov 2, 2022
pr_summary: warn if we can't fetch author's name and email
a9181dd 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this pull request Nov 10, 2022
@renawolford6
pr_summary: warn if we can't fetch author's name and email
ce3bda0 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this pull request Jan 27, 2023
@logictitans
pr_summary: warn if we can't fetch author's name and email
d35cc2f 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this pull request Jan 27, 2023
@gerkai
pr_summary: warn if we can't fetch author's name and email
6e633df 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this pull request Sep 14, 2023
@patrickm68
pr_summary: warn if we can't fetch author's name and email
294f53f 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete link and maybe info in crypto.md
7 participants
@antoine-amara @vsemozhetbyt @Trott @tniessen @MylesBorins @BridgeAR @nodejs-github-bot