src: use non-deprecated V8 microtasks API #18753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetAutorunMicrotasks is deprecated and a warning will be emitted starting from V8 6.5. Use the non-deprecated SetMicrotasksPolicy API instead.
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Feb 13, 2018
daynin
approved these changes
Feb 13, 2018
BridgeAR
added
the
author ready
apapirovski
approved these changes
Feb 13, 2018
cjihrig
approved these changes
Feb 13, 2018
benjamingr
approved these changes
Feb 13, 2018
jasnell
approved these changes
Feb 13, 2018
tniessen
approved these changes
Feb 14, 2018
TimothyGu
approved these changes
Feb 14, 2018
danbev
approved these changes
Feb 14, 2018
hashseed
approved these changes
Feb 15, 2018
|
Landed in a16081c |
targos
added a commit
that referenced
this pull request
Feb 15, 2018
SetAutorunMicrotasks is deprecated and a warning will be emitted starting from V8 6.5. Use the non-deprecated SetMicrotasksPolicy API instead. PR-URL: #18753 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
SetAutorunMicrotasks is deprecated and a warning will be emitted starting from V8 6.5. Use the non-deprecated SetMicrotasksPolicy API instead. PR-URL: nodejs#18753 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetAutorunMicrotasks is deprecated and a warning will be emitted
starting from V8 6.5. Use the non-deprecated SetMicrotasksPolicy API
instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8, src
CI: https://ci.nodejs.org/job/node-test-commit/16207/