Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add fs declarations to stream doc js examples #18804

Closed
wants to merge 1 commit into from
Closed

doc: add fs declarations to stream doc js examples #18804

wants to merge 1 commit into from

Conversation

prog1dev
Copy link
Contributor

@prog1dev prog1dev commented Feb 15, 2018 •
edited
Loading

Noticed that const fs = require('fs'); declaration is missing in some stream doc examples. So if you copy-paste code you get:

ReferenceError: fs is not defined

Here is a code example

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • Version: master
  • Platform: all
  • Subsystem: doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Feb 15, 2018
@prog1dev
Copy link
Contributor Author

prog1dev commented Feb 15, 2018 •
edited
Loading

ping @jasnell @mcollina
Dont know who else I should mention

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2018
@BridgeAR
Copy link
Member

CI-Light: https://ci.nodejs.org/job/node-test-commit-light/274/

vsemozhetbyt pushed a commit that referenced this pull request Feb 16, 2018
@prog1dev @vsemozhetbyt
doc: add fs declarations to stream doc js examples
755d805 
PR-URL: #18804
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 755d805

@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

targos pushed a commit that referenced this pull request Mar 24, 2018
@prog1dev @targos
doc: add fs declarations to stream doc js examples
ed55386 
PR-URL: #18804
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v9.x labels Mar 24, 2018
@prog1dev prog1dev deleted the add_missing_fs_declarations_in_stream_docs branch March 27, 2018 17:17
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@prog1dev @MayaLekova
doc: add fs declarations to stream doc js examples
bc7a7e1 
PR-URL: nodejs#18804
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@prog1dev @BridgeAR @vsemozhetbyt @MylesBorins @jasnell @starkwang @targos @nodejs-github-bot