[v9.x backport] src: fix GetCpuProfiler() deprecation warning #18959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `v8::Isolate::GetCpuProfiler()` with `v8::CpuProfiler::New()` and cache the instance; creating and disposing an instance every loop tick is too expensive. PR-URL: nodejs#18534 Fixes: nodejs#18039 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
nodejs-github-bot
added
c++
evanlucas
approved these changes
Feb 23, 2018
cjihrig
approved these changes
Feb 23, 2018
addaleax
force-pushed
the
v9.x-staging
branch
from
2177138
to
319cd44
Compare
MylesBorins
force-pushed
the
v9.x-staging
branch
from
19c46aa
to
1246902
Compare
|
Some failures, checking again: https://ci.nodejs.org/job/node-test-pull-request/13383/ |
addaleax
pushed a commit
that referenced
this pull request
Feb 27, 2018
Replace `v8::Isolate::GetCpuProfiler()` with `v8::CpuProfiler::New()` and cache the instance; creating and disposing an instance every loop tick is too expensive. Backport-PR-URL: #18959 PR-URL: #18534 Fixes: #18039 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
|
Landed on v9.x-staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
v8::Isolate::GetCpuProfiler()withv8::CpuProfiler::New()and cache the instance; creating and disposing an instance every loop
tick is too expensive.
PR-URL: #18534
Fixes: #18039
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src