doc: update 2fa information in onboarding.md #18968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this.
| GitHub account. Unless two-factor authentication is enabled, do not give an | ||
| account elevated privileges such as the ability to land code in the main | ||
| repository or to start continuous integration (CI) jobs. | ||
| * If the new Collaborator is not yet a member of the nodejs GitHub organization, |
There was a problem hiding this comment.
A nit: nodejs -> Node.js?
vsemozhetbyt
approved these changes
Feb 24, 2018
vsemozhetbyt
added
the
meta
ChALkeR
approved these changes
Feb 24, 2018
starkwang
approved these changes
Feb 24, 2018
lpinca
approved these changes
Feb 24, 2018
daynin
approved these changes
Feb 24, 2018
cjihrig
approved these changes
Feb 24, 2018
BridgeAR
approved these changes
Feb 24, 2018
BridgeAR
added
the
author ready
mmarchini
approved these changes
Feb 26, 2018
|
Landed in 1460b31 |
Leko
pushed a commit
that referenced
this pull request
Feb 26, 2018
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: #18968 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Feb 26, 2018
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: nodejs#18968 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 26, 2018
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: #18968 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Closed
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: nodejs#18968 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
|
No reason to backport this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it is no longer possible to add someone to the nodejs GitHub
organization if they do not have two-factor authentication enabled,
update the text of the onboarding documentatino to reflect this.
Checklist
Affected core subsystem(s)
doc