Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] trace_events: add file pattern cli option #19145

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] trace_events: add file pattern cli option #19145

wants to merge 1 commit into from

Conversation

AndreasMadsen
Copy link
Member

Allow the user to specify the filepath for the trace_events log file
using a template string.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

trace-events

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Mar 5, 2018
@AndreasMadsen AndreasMadsen added trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. semver-minor PRs that contain new features and should be released in the next minor version. labels Mar 5, 2018
@AndreasMadsen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13499/

@gibfahn gibfahn self-assigned this Mar 5, 2018
@AndreasMadsen
trace_events: add file pattern cli option
3f4abce 
Allow the user to specify the filepath for the trace_events log file
using a template string.

PR-URL: #18480
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@AndreasMadsen
Copy link
Member Author

Failed because we create temporary directories differently in node 8 in our tests.

CI: https://ci.nodejs.org/job/node-test-pull-request/13545/

@AndreasMadsen
Copy link
Member Author

AndreasMadsen commented Mar 7, 2018 •
edited
Loading

Unrelated test failure:

955 parallel/test-http2-respond-file-compat  
  duration_ms 0.266
  duration_ms 0.266
  severity fail
  stack (node:24361) ExperimentalWarning: The http2 module is an experimental API.

@MylesBorins MylesBorins force-pushed the v8.x-staging branch 2 times, most recently from 44cb0d3 to 16bf5fe Compare March 30, 2018 03:28
@MylesBorins
Copy link
Contributor

@nodejs/lts @nodejs/collaborators I'm landing this on staging preparing for a semver-minor release. Please lmk if you htink we should back it out

@MylesBorins
Copy link
Contributor

landed in a1d0e5a040

MylesBorins pushed a commit that referenced this pull request May 22, 2018
@AndreasMadsen @MylesBorins
trace_events: add file pattern cli option
141e3e9 
Allow the user to specify the filepath for the trace_events log file
using a template string.

Backport-PR-URL: #19145
PR-URL: #18480
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@AndreasMadsen @MylesBorins
trace_events: add file pattern cli option
5eb245c 
Allow the user to specify the filepath for the trace_events log file
using a template string.

Backport-PR-URL: #19145
PR-URL: #18480
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@AndreasMadsen @rvagg
trace_events: add file pattern cli option
e602726 
Allow the user to specify the filepath for the trace_events log file
using a template string.

Backport-PR-URL: #19145
PR-URL: #18480
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gibfahn gibfahn

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreasMadsen @MylesBorins @gibfahn @nodejs-github-bot