Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: emit 'close' after 'end' #19241

Closed
wants to merge 2 commits into from
Closed

net: emit 'close' after 'end' #19241

wants to merge 2 commits into from

Commits on Mar 21, 2018

  1. net: emit 'close' after 'end' 

    Currently the writable side of the socket is closed as soon as `UV_EOF`
is read regardless of the state of the socket. This allows the handle
to be closed before `'end'` is emitted and thus `'close'` can be
emitted before `'end'` if the socket is paused.

This commit prevents the handle from being closed until `'end'` is
emitted ensuring the correct order of events.

Fixes: nodejs#19166
    @lpinca
    lpinca committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    d25dea7 View commit details
    Browse the repository at this point in the history

  2. test: refactor test-cluster-send-deadlock 

    Wait for the sockets to be connected before closing them and remove
unneeded `setTimeout()`.
    @lpinca
    lpinca committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    5b957e1 View commit details
    Browse the repository at this point in the history