Revert "util: use blue on non-windows systems for number/bigint"

[BridgeAR]

This reverts commit 1708af3.

Numbers are much more difficult to read in blue and it would be good
to have a consistent output throughout all OS.

Refs: #18925

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/13605/

[devsnek]

i understand consistent output but Numbers are much more difficult to read in blue is objective based on your stylistic choices for your terminal. i won't block this but i am opposed to it.

[BridgeAR]

@devsnek that is correct but the same applies to using blue. I personally would like to have a consistent output throughout all OS as well and I think changing it was a mistake.

[gibfahn]

that is correct but the same applies to using blue.

AIUI the original colour was blue, then it was changed everywhere to make it easier to read on Windows. In my experience yellow on a white background is about as hard to read as blue on a black background, and differentiating numbers from other things is definitely useful.

I personally would like to have a consistent output throughout all OS as well

Why?

Fundamentally we're not going to find something that works perfectly in all terminals, so I think the current master is a good compromise.

So I'd be -1 on this PR.

EDIT: If I'm the only one disagreeing then I won't stand in the way of this PR, so -0.

[BridgeAR]

Numbers were yellow for six years now...

I wonder if changing it to blue should not have been a BC actually. Likely a lot of people will have to switch their setting now. There is no "right" or "wrong" since in each case people will be unhappy but I would like to stick to the way it was instead of breaking the old behavior.

[ChALkeR]

Tested on all pre-bundled color schemes of KDE terminal — Konsole.

Yellow looks good on all 12 of them (including ones with white bg).

Blue looks unreadable on 3 (25%) of them, including the probably widely used «White on black» colorscheme.

Given that I don't remember significant complaints about the previous colorscheme over long time, I suggest to revert to it.

[lpinca]

I have no strong opinion, I'm fine with both colors so I won't approve nor block this.

[ChALkeR]

Also, in standard Linux virtual console blue looks much less readable than yellow.
To test: printf "\x1B[34m001\n\x1B[0m"; printf "\x1B[33m001\n\x1B[0m";

[addaleax]

@nodejs/tsc If there are no objections, I’d like to land this soon – it’s a revert and I think we shouldn’t be shy about that.

I do agree that blue looks nice, but even in that case we should probably stick to the current default, and maybe provide some way to configure things via an env var or so if we want to. ¯\_(ツ)_/¯

[gibfahn]

If there are no objections, I’d like to land this soon – it’s a revert and I think we shouldn’t be shy about that.

SGTM

[addaleax]

Landed in 1329844