Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: improve Weak(Map|Set) support #19259

Closed
wants to merge 2 commits into from

Commits on Mar 23, 2018

  1. util: improve iterator inspect output

    1) So far extra keys on an (Set|Map)Iterator were ignored. Those
       will now be visible.
    2) Improve the performance of showing (Set|Map)Iterator by using
       the cloned iterator instead of copying all entries first.
    3) So far the output was strictly limited to up to 100 entries.
       The limit will now depend on `maxArrayLength` instead (that
       default is set to 100 as well) and the output indicates that
       more entries exist than visible.
    BridgeAR committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    83a25ae View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2018

  1. util: show Weak(Set|Map) entries in inspect

    This adds support for WeakMap and WeakSet entries in `util.inspect`.
    The output is limited to a maximum entry length of `maxArrayLength`.
    
    Fixes: nodejs#19001
    BridgeAR committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    f1e0752 View commit details
    Browse the repository at this point in the history