Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix path in doctool/test-doctool-json #19287

Closed
wants to merge 1 commit into from
Closed

test: fix path in doctool/test-doctool-json #19287

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This seems to slip in #17820

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 11, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 11, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13629/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2018
vsemozhetbyt added a commit that referenced this pull request Mar 11, 2018
@vsemozhetbyt
test: fix path in doctool/test-doctool-json
0048169 
PR-URL: #19287
Refs: #17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 0048169

@vsemozhetbyt vsemozhetbyt deleted the test-doctool-json-fix-path branch March 11, 2018 21:04
targos pushed a commit that referenced this pull request Mar 17, 2018
@vsemozhetbyt @targos
test: fix path in doctool/test-doctool-json
2d3ef5a 
PR-URL: #19287
Refs: #17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@vsemozhetbyt @MylesBorins
test: fix path in doctool/test-doctool-json
84ae59e 
PR-URL: #19287
Refs: #17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@vsemozhetbyt @MayaLekova
test: fix path in doctool/test-doctool-json
fc24f3f 
PR-URL: nodejs#19287
Refs: nodejs#17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 16, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @Trott @lpinca @BethGriggs @nodejs-github-bot