[6.x] Revert "fs: fix options.end of fs.ReadStream()" #19326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
|
Here's the test build https://nodejs.org/download/test/v6.13.2-test20180313acaeb8f006/ |
This reverts commit df038ad. Some people were relying on the behavior of this.start being able to be undefined, whereas after the change it is being set to 0. Fixes: nodejs#19240 Refs: nodejs#18121
MylesBorins
force-pushed
the
revert-options-fix-6.x
branch
from
acaeb8f to
d579aed
Compare
MylesBorins
changed the title
MylesBorins
changed the title
|
setting as blocked for right now as @addaleax may have a PR to fix this |
3 tasks
|
@MylesBorins Ran the test build. Did not hit the same error as with v6.13.1. Looks good to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit df038ad.
Some people were relying on the behavior of this.start being able to be
undefined, whereas after the change it is being set to 0.
Fixes: #19240:
Refs: #18121
/cc @wankdanker @MoonBall @nodejs/lts