Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix nits in tools/doc/common.js #19599

Closed
wants to merge 1 commit into from
Closed

tools: fix nits in tools/doc/common.js #19599

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 25, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  1. Replace .match() with .test() in a boolean context.
  2. Concentrate exports.
  3. Remove obsolete "safety fuse" replacer (was meant to guard against backticks at the beginning of the lines, but it is not a common practice anymore and we has no cases for this pattern match now). This change is approved by @addaleax (the deleted block was added here).

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 25, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 25, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/333/

Let me know if we need full CI for this.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2018
vsemozhetbyt added a commit that referenced this pull request Mar 25, 2018
@vsemozhetbyt
tools: fix nits in tools/doc/common.js
50e5eff 
PR-URL: #19599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 50e5eff

@vsemozhetbyt vsemozhetbyt deleted the tools-doc-common branch March 25, 2018 18:52
targos pushed a commit that referenced this pull request Mar 27, 2018
@vsemozhetbyt @targos
tools: fix nits in tools/doc/common.js
4c3465f 
PR-URL: #19599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@vsemozhetbyt @MylesBorins
tools: fix nits in tools/doc/common.js
fe4e511 
PR-URL: #19599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @addaleax @lpinca @MylesBorins @nodejs-github-bot