-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: ICU 61.1 bump #19621
Merged
Merged
deps: ICU 61.1 bump #19621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
meta
Issues and PRs related to the general management of the project.
labels
Mar 26, 2018
cjihrig
approved these changes
Mar 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubberstamp LGTM
jasnell
approved these changes
Mar 28, 2018
ooh, almost forgot:
|
targos
pushed a commit
that referenced
this pull request
Apr 3, 2018
- Update to released ICU 61.1, including: - CLDR 33 (many new languages and data improvements) - Many small API additions, improvements, and bug fixes - note: 'icu::' namespace is no longer used by default (Necessated #18667 ) PR-URL: #19621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this pull request
Apr 4, 2018
Notable changes: * deps: - Updated ICU to 61.1 (Steven R. Loomis) [#19621](#19621) Includes CLDR 33 (many new languages and data improvements). * fs: - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer Srivastava) [#19408](#19408) * n-api: - Bump version of n-api supported (Michael Dawson) [#19497](#19497) * net: - Emit 'ready' event for `Socket` (Sameer Srivastava) [#19408](#19408) * Added new collaborators - [mafintosh](https://github.com/mafintosh) Mathias Buus
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2018
Notable changes: * deps: - Updated ICU to 61.1 (Steven R. Loomis) [#19621](#19621) Includes CLDR 33 (many new languages and data improvements). * fs: - Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer Srivastava) [#19408](#19408) * n-api: - Bump version of n-api supported (Michael Dawson) [#19497](#19497) * net: - Emit 'ready' event for `Socket` (Sameer Srivastava) [#19408](#19408) * Added new collaborators - [mafintosh](https://github.com/mafintosh) Mathias Buus
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Necessated tools: add "icu::" namespace to ICU symbols #18667 )
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes