doc: improve assert legacy text #19622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes a sentence fragment into a full sentence and provides a few other minor improvements.
nodejs-github-bot
added
assert
vsemozhetbyt
approved these changes
Mar 26, 2018
vsemozhetbyt
added
fast-track
Leko
approved these changes
Mar 26, 2018
BridgeAR
approved these changes
Mar 27, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 27, 2018
This changes a sentence fragment into a full sentence and provides a few other minor improvements. PR-URL: nodejs#19622 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 12f69dd 🎉 |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
This changes a sentence fragment into a full sentence and provides a few other minor improvements. PR-URL: #19622 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
This changes a sentence fragment into a full sentence and provides a few other minor improvements. PR-URL: #19622 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a sentence fragment into a full sentence and provides a few
other minor improvements.
Checklist