doc: remove "if provided" for optional arguments #19690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
TimothyGu
approved these changes
Mar 30, 2018
Adsada2205
approved these changes
Mar 30, 2018
Adsada2205
approved these changes
Mar 30, 2018
lpinca
approved these changes
Mar 30, 2018
lpinca
added
the
author ready
trivikr
approved these changes
Mar 30, 2018
vsemozhetbyt
approved these changes
Mar 30, 2018
Leko
approved these changes
Mar 30, 2018
cjihrig
approved these changes
Mar 30, 2018
targos
approved these changes
Mar 30, 2018
jasnell
approved these changes
Apr 1, 2018
Remove "if provided" when discussing arguments that are explicitly indicated to be optional and have default values.
|
Landed in 6de1a12 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 2, 2018
Remove "if provided" when discussing arguments that are explicitly indicated to be optional and have default values. PR-URL: nodejs#19690 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
Remove "if provided" when discussing arguments that are explicitly indicated to be optional and have default values. PR-URL: #19690 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
Remove "if provided" when discussing arguments that are explicitly indicated to be optional and have default values. PR-URL: #19690 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "if provided" when discussing arguments that are explicitly
indicated to be optional and have default values.
Checklist