Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: shorten deprecation warning #19741

Closed
wants to merge 1 commit into from
Closed

buffer: shorten deprecation warning #19741

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 2, 2018

Remove "construction" from the deprecation warning for Buffer
constructor.

Ref: #19687 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Apr 2, 2018
@Trott Trott force-pushed the no-construction branch 2 times, most recently from d2a4dc3 to b256c9e Compare April 2, 2018 05:25
@Trott
buffer: shorten deprecation warning
56e9814 
Shorten the deprecation warning for Buffer constructor.

Ref: nodejs#19687 (review)
@Trott
Copy link
Member Author

Trott commented Apr 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13982/

@Trott
Copy link
Member Author

Trott commented Apr 2, 2018

Re-runs for seemingly-unrelated CI failures.

node-test-commit-osx: https://ci.nodejs.org/job/node-test-commit-osx/17425/
node-test-commit-arm: https://ci.nodejs.org/job/node-test-commit-arm/15005/

@jasnell
Copy link
Member

jasnell commented Apr 2, 2018

Please do a CITGM run. Changing the console output could, theoretically, be breaking here.

@Trott
Copy link
Member Author

Trott commented Apr 2, 2018

node-test-commit-osx was green on re-run.

Re-run node-test-commit-arm: https://ci.nodejs.org/job/node-test-commit-arm/15024/

@Trott
Copy link
Member Author

Trott commented Apr 2, 2018

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1347/

@Trott
Copy link
Member Author

Trott commented Apr 3, 2018

Re-re-re-run node-test-commit-arm: https://ci.nodejs.org/job/node-test-commit-arm/15062/

@Trott
Copy link
Member Author

Trott commented Apr 3, 2018

(CI is all green now. Still need to check CITGM results.)

@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

Apparently I didn't start the CITGM job with the correct parameters. Let's try again: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1348/

@ChALkeR
Copy link
Member

ChALkeR commented Apr 4, 2018

@Trott LGTM, but I would suggest avoiding landing this on anything below 10.x.
No need to mark it as a semver-major imo if CITGM is fine, though.

@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

CITGM results look good (to me, at least).

Trott added a commit to Trott/io.js that referenced this pull request Apr 4, 2018
@Trott
buffer: shorten deprecation warning
3d61e14 
Shorten the deprecation warning for Buffer constructor.

PR-URL: nodejs#19741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

Landed in 3d61e14

@Trott Trott closed this Apr 4, 2018
@Trott Trott deleted the no-construction branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @ChALkeR @cjihrig @trivikr @nodejs-github-bot