Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] doc: fix various nits #19753

Closed
wants to merge 5 commits into from
Closed

[v8.x backport] doc: fix various nits #19753

wants to merge 5 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Backport of #19743 (proactive).

Commit 1: replace 2 hyphens (--) by spaced m-dash () as per STYLE_GUIDE.md.
Commit 2: space infix operators.
Commit 3: unify quotes in inline code spans (use only single quotes).
Commit 4: unify * Returns: (eliminate deviations).
Commit 5: dedupe spaces.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Apr 2, 2018
@vsemozhetbyt
Copy link
Contributor Author

Refs: #19743 (review)

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 2, 2018
3 tasks
@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 4, 2018

I've copied the landed PR metadata in the first commit and reword titles in the other commits to hint fixup.

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/420/

* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md.
* Space infix operators.
* Unify quotes in inline code spans (use only single quotes).
* Unify `* Returns:` (eliminate deviations).
* Dedupe spaces.

PR-URL: #19743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2018
gibfahn pushed a commit that referenced this pull request Apr 11, 2018
* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md.
* Space infix operators.
* Unify quotes in inline code spans (use only single quotes).
* Unify `* Returns:` (eliminate deviations).
* Dedupe spaces.

PR-URL: #19743
Backport-PR-URL: #19753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Apr 12, 2018

Landed in c897815

@gibfahn gibfahn closed this Apr 12, 2018
@vsemozhetbyt vsemozhetbyt deleted the backport-19743-to-v8.x branch April 12, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants