doc: remove _writableState reference #20004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapirovski
added
doc
nodejs-github-bot
added
doc
|
/cc @nodejs/documentation |
lpinca
approved these changes
Apr 13, 2018
doc/api/stream.md
Outdated
| const state = this._writableState; | ||
| this._decoder = new StringDecoder(state.defaultEncoding); | ||
| const encoding = options ? options.defaultEncoding : 'utf8'; | ||
| this._decoder = new StringDecoder(encoding); |
There was a problem hiding this comment.
Nit: it could be just options && options.defaultEncoding.
There was a problem hiding this comment.
Ah, yeah. Good point.
BridgeAR
approved these changes
Apr 13, 2018
apapirovski
force-pushed
the
patch-doc-remove-writablestate
branch
from
d07372c to
4b88254
Compare
BridgeAR
added
the
author ready
danbev
approved these changes
Apr 13, 2018
tniessen
approved these changes
Apr 13, 2018
cjihrig
approved these changes
Apr 13, 2018
jasnell
approved these changes
Apr 13, 2018
|
Landed in 4082bdf 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 13, 2018
PR-URL: nodejs#20004 Fixes: nodejs#6799 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
removed
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #20004 Fixes: #6799 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#20004 Fixes: nodejs#6799 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc currently includes one last reference to
_writableStatewhich can easily be removed.Fixes: #6799
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes