Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Revert 17907: util: change inspect depth default #20089

Closed
wants to merge 2 commits into from
Closed

[10.x] Revert 17907: util: change inspect depth default #20089

wants to merge 2 commits into from

Commits on Apr 16, 2018

  1. Revert "util: change %o depth default" 

    This reverts commit 8f15309.
    @addaleax @jasnell
    addaleax authored and jasnell committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    a51f38c View commit details
    Browse the repository at this point in the history

  2. Revert "util: change util.inspect depth default" 

    This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

Fixes: #19405
Refs: #17907
    @addaleax @jasnell
    addaleax authored and jasnell committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    0bbc356 View commit details
    Browse the repository at this point in the history