Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] deps: V8: backport 76c3ac5 from upstream #20156

Closed
wants to merge 5 commits into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Apr 19, 2018

This is a v6.x backport of 00687fb.

Ref: #18298
Ref: v8/v8@76c3ac5

CI: https://ci.nodejs.org/job/node-test-pull-request/14390/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1332/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Apr 19, 2018
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch level should be bumped in v8-version.h.

@ofrobots
Copy link
Contributor Author

@richardlau done.

@MylesBorins
Copy link
Contributor

Looks like real failures 😢

16:20:18 ../test/cctest/test-cpu-profiler.cc:1672:29: error: no member named 'use_optimizer' in 'v8::internal::Isolate'
16:20:18   if (!CcTest::i_isolate()->use_optimizer() || i::FLAG_always_opt) return;
16:20:18        ~~~~~~~~~~~~~~~~~~~  ^
16:20:18 ../test/cctest/test-cpu-profiler.cc:1677:3: error: unknown type name 'ProfilerHelper'
16:20:18   ProfilerHelper helper(env);

@ofrobots
Copy link
Contributor Author

Okay, so the test compiles now, but right now I am playing whackamole with how CrankShaft ends up being different from TurboFan and the various different ways the profiles different at runtime.

As a starting point, CrankShaft is unable to inline functions with let in them, so that why we needed precise line numbers in d4e7d4c.

There is a second round of failure (missing script id for alpha) on the test that I need to look into.

@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

Ping @ofrobots

@lundibundi
Copy link
Member

@ofrobots are you still interested in this PR or can it be closed?

@ofrobots
Copy link
Contributor Author

Abandoning. This is not worth pursing at this point.

@ofrobots ofrobots closed this Sep 28, 2018
@ofrobots ofrobots deleted the backport-6-18298 branch September 28, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants