-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] deps: V8: backport 76c3ac5 from upstream #20156
Conversation
This is a v6.x backport of 00687fb. Ref: nodejs#18298 Ref: v8/v8@76c3ac5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch level should be bumped in v8-version.h.
@richardlau done. |
Looks like real failures 😢
|
5bed30a
to
e34c7b8
Compare
Okay, so the test compiles now, but right now I am playing whackamole with how CrankShaft ends up being different from TurboFan and the various different ways the profiles different at runtime. As a starting point, CrankShaft is unable to inline functions with There is a second round of failure (missing script id for |
Ping @ofrobots |
@ofrobots are you still interested in this PR or can it be closed? |
Abandoning. This is not worth pursing at this point. |
This is a v6.x backport of 00687fb.
Ref: #18298
Ref: v8/v8@76c3ac5
CI: https://ci.nodejs.org/job/node-test-pull-request/14390/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1332/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes