Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove "For example" expression in N-API doc #20187

Closed
wants to merge 1 commit into from
Closed

doc: remove "For example" expression in N-API doc #20187

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Re #20161

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Apr 21, 2018
@Trott
Copy link
Member

Trott commented Apr 21, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/562/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Apr 21, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for fast-track

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 21, 2018
@Trott
Copy link
Member

Trott commented Apr 21, 2018

+1 for fast-track

@gabrielschulhof
Copy link
Contributor Author

Landed in a71f9ba.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 21, 2018
doc: remove "For example" expression in N-API doc
a71f9ba 
PR-URL: nodejs#20187
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gabrielschulhof gabrielschulhof deleted the n-api-remove-for-example branch April 21, 2018 14:24
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@jasnell
doc: remove "For example" expression in N-API doc
3d76055 
PR-URL: #20187
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gabrielschulhof @Trott @bnoordhuis @lpinca @richardlau @vsemozhetbyt @trivikr @nodejs-github-bot