Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use -9 with kill in Makefile #20195

Closed
wants to merge 1 commit into from
Closed

build: use -9 with kill in Makefile #20195

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 21, 2018

Fixes: #20194

@nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 21, 2018
@Trott
Copy link
Member Author

Trott commented Apr 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14415/

@Trott
Copy link
Member Author

Trott commented Apr 21, 2018

Re-run Linux CI: https://ci.nodejs.org/job/node-test-commit-linux/18165/
Re-run SmartOS CI: https://ci.nodejs.org/job/node-test-commit-smartos/17063/

@Trott
Copy link
Member Author

Trott commented Apr 21, 2018

Yet another Linux re-run: https://ci.nodejs.org/job/node-test-commit-linux/18173/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2018
@joyeecheung joyeecheung mentioned this pull request Apr 24, 2018
Closed
4 tasks
@Trott Trott mentioned this pull request Apr 24, 2018
Merged
Trott added a commit to Trott/io.js that referenced this pull request Apr 24, 2018
@Trott
build: use -9 with kill in Makefile
7424d86 
Fixes: nodejs#20194

PR-URL: nodejs#20195
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member Author

Trott commented Apr 24, 2018

Landed in 7424d86

@Trott Trott closed this Apr 24, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@Trott @MylesBorins
build: use -9 with kill in Makefile
c5b3459 
Fixes: #20194

PR-URL: #20195
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
@Trott Trott deleted the dash-9 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handling of stray jobs that need terminating in CI
7 participants
@Trott @addaleax @lpinca @TimothyGu @cjihrig @BridgeAR @nodejs-github-bot