Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS 2015 support #2036

Merged
merged 3 commits into from
Jun 25, 2015
Merged

VS 2015 support #2036

merged 3 commits into from
Jun 25, 2015

Commits on Jun 25, 2015

  1. build,win: set env before generating projects 

    vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR-URL: nodejs/node-v0.x-archive#20109
    @orangemocha @rvagg
    orangemocha authored and rvagg committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    c0c0d73 View commit details
    Browse the repository at this point in the history

  2. build: add MSVS 2015 support 

    PR-URL: nodejs#2036
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
    @rvagg
    rvagg committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    4208dc4 View commit details
    Browse the repository at this point in the history

  3. build: fix cherry-pick ooops, fix comment wording 

    PR-URL: nodejs#2036
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
    @rvagg
    rvagg committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    c87c34c View commit details
    Browse the repository at this point in the history