url: call onParsePortComplete on null port from onParseHostComplete
#20476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call `onParsePortComplete` on null port from `onParseHostComplete` to set url’s port to null, if port is url’s scheme’s default port, and to port otherwise, as specified in the spec. Also, trim all trailing `:` from `host` in the setter to fix regressions caused by the change. Refs: https://url.spec.whatwg.org/#port-state Fixes: nodejs#20465
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
|
|
|
Closing in favor of an upcoming better PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
onParsePortCompleteon null port fromonParseHostCompletetoset url’s port to null, if port is url’s scheme’s default port,
and to port otherwise, as specified in the spec.
Also, trim all trailing
:fromhostin the setter to fixregressions caused by the change.
Refs: https://url.spec.whatwg.org/#port-state
Fixes: #20465
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes